This repository has been archived by the owner on Jul 29, 2024. It is now read-only.
add jasmine2 framework #1675
Closed
add jasmine2 framework #1675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hankduan
force-pushed
the
jasmine2
branch
3 times, most recently
from
02abbc2
to
a1291a6
Compare
|
Docs to go along with this: #1679 |
|
Note that the travis error is due to jasminewd2 not yet being published. |
| @@ -236,7 +236,7 @@ exports.config = { | |||
| // ----- The test framework -------------------------------------------------- | |||
| // --------------------------------------------------------------------------- | |||
|
|
|||
| // Test framework to use. This may be jasmine, cucumber, or mocha. | |||
| // Test framework to use. This may be jasmine, jasmine2, cucumber, or mocha. | |||
There was a problem hiding this comment.
Let's change the value listed below to 'jasmine2' as well
There was a problem hiding this comment.
As in "Jasmine2 is fully supported as a test and assertion framework."?
|
Change the default value in configParser to jasmine2 |
| @@ -12,10 +12,16 @@ describe('locators', function() { | |||
|
|
|||
| it('should allow custom expectations to expect an element', function() { | |||
| this.addMatchers({ | |||
There was a problem hiding this comment.
It might be helpful to show an example more like this in the documentation PR.
There was a problem hiding this comment.
replaced the example in the documentation PR with this.
|
LGTM once Travis passes. |
|
committed with 1e60a95 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables protractor to work with jasmine2.0 (see #362)
Pending angular/jasminewd#13 for the release of jasminewd2
Note, passing timeout as part of
it,fit, etc does not work yet. Pending jasmine/jasmine@a4faa80Also, stacktrace is messed up when calling
done.fail('xyz')because jasmine2 does not allow custom stacktrace. Filed an issue at jasmine/jasmine#734