Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve precision of PR 1334 #1335

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Improve precision of PR 1334 #1335

merged 1 commit into from
Dec 6, 2023

Conversation

angularsen
Copy link
Owner

Fixup of 202eafa - Add density unit PoundsPerCubicYard + Kilo prefix (#1334)

Use precise calculation from definitions.

Fixup of 202eafa - Add density unit PoundsPerCubicYard + Kilo prefix (#1334)

Use precise calculation from definitions.
@angularsen
Copy link
Owner Author

@aharres I realized the calculation could be improved after I merged, so I did it here.

@angularsen angularsen merged commit edf08b9 into master Dec 6, 2023
1 check was pending
@angularsen angularsen deleted the agl/fixup-1334 branch December 6, 2023 05:26
@angularsen
Copy link
Owner Author

angularsen added a commit that referenced this pull request Dec 7, 2023
Forgot to push new generated code, breaking tests.
angularsen added a commit that referenced this pull request Dec 7, 2023
Weird, third time I could not get this right. All tests green locally now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant