Constrained the GenericMathExtensions to IQuantity #1448
Conversation
- replaced the aggregation with an iterator based version (slightly faster) - the Average extension now throws an InvalidOperationException when the source is empty
| { | ||
| IEnumerable<Length> values = [Length.FromCentimeters(100), Length.FromCentimeters(200)]; | ||
|
|
||
| Length sumOfQuantities = GenericMathExtensions.Sum(values); |
There was a problem hiding this comment.
The reason I'm not using values.Sum() is because when we add the IVectorQuantity interface, this is going to start testing the other extension method (which is a better/more specific match for the list of Length).
| if (!e.MoveNext()) | ||
| { | ||
| throw new InvalidOperationException("Sequence contains no elements"); | ||
| } |
There was a problem hiding this comment.
Notice this: in v5 this case would have caused an exception to be thrown because of the NaN, however as we disabled the guard in v6- this would not have thrown an exception.
This is also the behavior of Average(IEnumerable<Double>).
|
I think I already mentioned this in #1200 but these method are still applicable to the logarithmic quantities, which implement both [Fact(Skip = "Fix in v6")]
public void AdditiveIdentityIsIncorrect()
{
var expectedQuantity = PowerRatio.FromDecibelMilliwatts(24);
AssertEx.EqualTolerance(expectedQuantity.DecibelMilliwatts, (expectedQuantity + PowerRatio.AdditiveIdentity).DecibelMilliwatts, DecibelMilliwattsTolerance);
}With the addition of the new interfaces, the logarithmic quantities are going to lose their |
|
Oh, and by the way- if you need to test the performance difference there are a few benchmarks available for the |
InvalidOperationExceptionwhen the source is empty