Merge pull request #124 from paviliondev/fix_failing_qunit_test

FIX: test intermittently fails due to render race condition
angusmcleod · Sep 29, 2023 · c18cbee · c18cbee
2 parents ad75d20 + f48fbb2
commit c18cbee
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/plugin.rb b/plugin.rb
@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 # name: discourse-events
 # about: Allows you to manage events in Discourse
-# version: 0.2.5
+# version: 0.2.6
 # authors: Angus McLeod
 # contact_emails: [email protected]
 # url: https://github.com/paviliondev/discourse-events

diff --git a/test/javascripts/acceptance/admin-connection-test.js b/test/javascripts/acceptance/admin-connection-test.js
@@ -5,7 +5,7 @@ import {
   query,
 } from "discourse/tests/helpers/qunit-helpers";
 import { test } from "qunit";
-import { visit } from "@ember/test-helpers";
+import { settled, visit } from "@ember/test-helpers";
 import { registerRoutes } from "../helpers/events-routes";
 
 function sourceRoutes(needs) {
@@ -122,6 +122,7 @@ acceptance("Events | Connection", function (needs) {
     const userSelect = selectKit("tr[data-connection-id=new] .connection-user");
     await userSelect.expand();
     await fillIn(".connection-user input.filter-input", "angus");
+    await settled();
     await userSelect.selectRowByValue("angus");
 
     await selectKit("tr[data-connection-id=new] .connection-category").expand();