Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 봉사자 회원가입 로직을 구현한다. #38

Merged
merged 13 commits into from
Oct 31, 2023
Merged

feat: 봉사자 회원가입 로직을 구현한다. #38

merged 13 commits into from
Oct 31, 2023

Conversation

funnysunny08
Copy link
Collaborator

⛏ 작업 사항

봉사자 회원가입 API

📝 작업 요약

  • 봉사자 회원가입 controller, service, requestDTO 작성
  • 봉사자 회원가입 requestDTO 작성
  • 봉사자 관련 도메인 검증 로직 작성
  • 관련 테스트 작성

💡 관련 이슈

@funnysunny08
feat: volunteer에 getter 함수를 구현한다.
58913a8
@funnysunny08
feat: VolunteerImage repository를 생성한다.
f9eff96
@funnysunny08
feat: RegisterVolunteerRequest dto를 생성한다.
8630cb8
@funnysunny08
feat: Volunteer entity validation을 추가한다.
fba48c3
@funnysunny08
feat: VolunteerImage에 Getter를 추가한다.
eac5bf3
@funnysunny08
feat: Volunteer birthDate validation 추가한다.
f93a150
@funnysunny08
feat: registerVolunteer 서비스 로직을 구현한다.
2c92a54
@funnysunny08
feat: registerVolunteer 컨트롤러 로직을 구현한다.
7df88b0
@funnysunny08
feat: 봉사자 회원가입 컨트롤러 테스트를 작성한다.
56e1508
@funnysunny08
feat: 봉사자 회원가입 서비스 테스트를 작성한다.
b335e09
@funnysunny08
feat: volunteer 도메인 테스트를 작성한다.
0d90814
@funnysunny08
refactor: dto fixture를 분리한다.
9bf5485
@funnysunny08
refactor: controller test에서 nest 제거한다.
5726562
@funnysunny08 funnysunny08 self-assigned this Oct 31, 2023
@funnysunny08 funnysunny08 added this to the sprint-1 milestone Oct 31, 2023
@sonarcloud
Copy link

sonarcloud bot commented Oct 31, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@github-actions
Copy link

Test Results

36 tests  +23   36 ✔️ +23   5s ⏱️ +3s
18 suites +  9     0 💤 ±  0 
18 files   +  9     0 ❌ ±  0 

Results for commit 5726562. ± Comparison against base commit 1786f59.

@bjo6300 bjo6300 merged commit 25e86a6 into dev Oct 31, 2023
5 of 6 checks passed
@bjo6300 bjo6300 deleted the feat/#34 branch October 31, 2023 16:34
@bjo6300 bjo6300 removed this from the sprint-1 milestone Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hseong3243 hseong3243 hseong3243 approved these changes

@bjo6300 bjo6300 bjo6300 approved these changes

@pushedrumex pushedrumex Awaiting requested review from pushedrumex pushedrumex is a code owner

Assignees

@funnysunny08 funnysunny08

Labels
✨ Feat
Projects
anifriends-backend-board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: 봉사자 회원가입 로직을 구현한다.
3 participants
@funnysunny08 @hseong3243 @bjo6300