Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 봉사자 마이페이지 조회 로직을 구현한다. #46

Merged
merged 11 commits into from
Nov 1, 2023
Merged

feat: 봉사자 마이페이지 조회 로직을 구현한다. #46

merged 11 commits into from
Nov 1, 2023

Conversation

funnysunny08
Copy link
Collaborator

⛏ 작업 사항

봉사자 마이페이지 조회 API

📝 작업 요약

  • 봉사자 마이페이지 조회 controller, service, repository, responseDTO 작성
  • 봉사자 이미지 도메인 검증 로직 작성
  • 관련 테스트 작성

💡 관련 이슈

@funnysunny08 funnysunny08 added this to the sprint-1 milestone Nov 1, 2023
@funnysunny08 funnysunny08 self-assigned this Nov 1, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 1, 2023 •
edited
Loading

Test Results

100 tests  +4   100 ✔️ +4   5s ⏱️ -1s
  49 suites +1       0 💤 ±0 
  49 files   +1       0 ❌ ±0 

Results for commit 6600fc9. ± Comparison against base commit 8e5c27f.

This pull request removes 1 and adds 5 tests. Note that renamed tests count towards both. 
com.clova.anifriends.domain.volunteer.VolunteerImageTest$NewVolunteerImageTest ‑ 성공

com.clova.anifriends.domain.volunteer.VolunteerImageTest$newVolunteerImageTest ‑ 성공
com.clova.anifriends.domain.volunteer.VolunteerImageTest$newVolunteerImageTest ‑ 예외: imageUrl이 null
com.clova.anifriends.domain.volunteer.VolunteerImageTest$newVolunteerImageTest ‑ 예외: volunteer가 null인 경우
com.clova.anifriends.domain.volunteer.controller.VolunteerControllerTest ‑ 봉사자 마이페이지 조회 API 호출 시
com.clova.anifriends.domain.volunteer.service.VolunteerServiceTest$FindVolunteerMyPageTest ‑ 성공

♻️ This comment has been updated with latest results.

pushedrumex
pushedrumex approved these changes Nov 1, 2023
View reviewed changes
Copy link
Member

@pushedrumex pushedrumex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니당!!

bjo6300
bjo6300 reviewed Nov 1, 2023
View reviewed changes
Copy link
Member

@bjo6300 bjo6300 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!

src/main/java/com/clova/anifriends/domain/volunteer/controller/VolunteerController.java Outdated Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

95.0% 95.0% Coverage
0.0% 0.0% Duplication

@funnysunny08 funnysunny08 merged commit a5b9751 into dev Nov 1, 2023
6 checks passed
@funnysunny08 funnysunny08 deleted the feat/#35 branch November 1, 2023 15:17
@bjo6300 bjo6300 removed this from the sprint-1 milestone Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjo6300 bjo6300 bjo6300 left review comments

@hseong3243 hseong3243 hseong3243 approved these changes

@pushedrumex pushedrumex pushedrumex approved these changes

Assignees

@funnysunny08 funnysunny08

Labels
✨ Feat
Projects
anifriends-backend-board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: 봉사자 마이페이지 조회 로직을 구현한다.
4 participants
@funnysunny08 @hseong3243 @bjo6300 @pushedrumex