Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add(components): Motion Primitives #569

Merged
merged 3 commits into from
Aug 20, 2024
Merged

add(components): Motion Primitives #569

merged 3 commits into from
Aug 20, 2024

Conversation

viruop
Copy link
Contributor

@viruop viruop commented Aug 17, 2024

Name Link
Motion Primitives https://motion-primitives.com

Beautifully designed motion components built using Tailwind CSS and Framer Motion

  • My item is in the right category
  • My item is logically grouped below similar items
  • My item's name and description respects the conventions of the list
  • My item is awesome
  • My item is in line with the Tailwind brand usage guidelines
  • I have read and followed the contribution guidelines

Copy link
Collaborator

@innocenzi innocenzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you shorten the description to a single sentence please?

@viruop
Copy link
Contributor Author

viruop commented Aug 20, 2024

Hi @innocenzi I've made some changes. Could you please take a look and merge them? Thanks!

@innocenzi innocenzi merged commit d854ee0 into aniftyco:master Aug 20, 2024
1 check passed
@innocenzi
Copy link
Collaborator

Thanks!

@joshmanders
Copy link
Member

@innocenzi @viruop Great library, would we benefit here from mentioning that they're React components? I don't have a lot of experience with Framer so maybe that's enough of a hint it's React, but the description doesn't mention React at all and at first glance I personally thought this was a library for Tailwind itself not a React library so I got a bit sad when I realized I couldn't use it in Vue.

@viruop
Copy link
Contributor Author

viruop commented Aug 21, 2024

@innocenzi @viruop Great library, would we benefit here from mentioning that they're React components? I don't have a lot of experience with Framer so maybe that's enough of a hint it's React, but the description doesn't mention React at all and at first glance I personally thought this was a library for Tailwind itself not a React library so I got a bit sad when I realized I couldn't use it in Vue.

Thanks for your feedback! Could you please reopen the PR so that I can update the description?

@joshmanders
Copy link
Member

@viruop probably be easier to just submit a new PR.

@viruop
Copy link
Contributor Author

viruop commented Aug 22, 2024

@viruop probably be easier to just submit a new PR.

Please review the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants