BUG: ssh rule created by default

same as ICMP
anish-mudaraddi · May 1, 2024 · 6d3acff · 6d3acff
1 parent b92215c
commit 6d3acff
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 15 deletions.
diff --git a/lib/openstack_api/openstack_security_groups.py b/lib/openstack_api/openstack_security_groups.py
@@ -30,13 +30,6 @@ def create_external_security_group_rules(
         """
         # default network external rules
         default_external_rules = [
-            {
-                "direction": NetworkDirection.INGRESS,
-                "ip_version": IPVersion.IPV4,
-                "protocol": Protocol.TCP,
-                "remote_ip_cidr": "0.0.0.0/0",
-                "port_range": ("22", "22"),
-            },
             {
                 "direction": NetworkDirection.EGRESS,
                 "ip_version": IPVersion.IPV4,

diff --git a/tests/lib/test_openstack_security_groups.py b/tests/lib/test_openstack_security_groups.py
@@ -208,13 +208,6 @@ def test_create_port_wildcard(self):
     # pylint:disable=too-many-arguments
     @parameterized.expand(
         [
-            (
-                NetworkDirection.INGRESS,
-                IPVersion.IPV4,
-                Protocol.TCP,
-                "0.0.0.0/0",
-                ("22", "22"),
-            ),
             (
                 NetworkDirection.EGRESS,
                 IPVersion.IPV4,
@@ -434,4 +427,4 @@ def test_external_security_rules_count(self):
             cloud, project_identifier, security_group_identifier
         )
 
-        assert self.instance.create_security_group_rule.call_count == 99
+        assert self.instance.create_security_group_rule.call_count == 98