fix: refactor HTTP error codes for PUT /mentorship_relation/{request_id}/task/{task_id}/comment/{comment_id} #1127
Conversation
|
@RiddhiAthreya the linked issue is a |
vj-codes
added
the
Status: Needs Review
vj-codes
added
Status: Changes Requested
There was a problem hiding this comment.
@RiddhiAthreya I see you remove the changes done for pre-commit. Please revert those changes.
| [flake8] | ||
| ignore = | ||
| # W503: line break before binary operator | ||
| # ignored as it creates inconsistency with black | ||
| W503, | ||
| # E501: line too long (> 88 characters) |
There was a problem hiding this comment.
Why this file is deleted?
This is important for flake8 to work correctly.
| @@ -7,16 +7,16 @@ | |||
| * When developing a new feature, include at least one test when applicable. | |||
| * When submitting a PR, please follow [this template](PULL_REQUEST_TEMPLATE.md) (which will probably be already filled up once you create the PR). | |||
| * When submitting a PR with changes to user interface (e.g.: new screen, or an email template), please add screenshots to the PR description. | |||
| * When you are finished with your work, please squash your commits otherwise we will squash them on your PR (this can help us maintain a clear commit history). | |||
| * When you are finished with your work, please squash your commits otherwise we will squash them on your PR (this can help us maintain a clear commit history). | |||
There was a problem hiding this comment.
There should not be any space at the end. Trim the whitespace please
| * When writing in-code documentation as Docstrings, please follow [this guide](https://github.com/google/styleguide/blob/gh-pages/pyguide.md#38-comments-and-docstrings). | ||
| * When creating an issue to report a bug in the project, please follow our [bug_report.md](https://github.com/anitab-org/.github/blob/main/.github/ISSUE_TEMPLATE/bug_report.md) template. | ||
|
|
||
| ## General Guidelines | ||
|
|
||
| * If you’re just getting started work on an issue labeled “First Timers Only” in any project. Additional resources are available on our [website](http://www.systers.io). | ||
| * In an active repository (not an archived one), choose an open issue from the issue list, claim it in the comments, and a maintainer will assign it to you. | ||
| * In an active repository (not an archived one), choose an open issue from the issue list, claim it in the comments, and a maintainer will assign it to you. |
There was a problem hiding this comment.
Same as above. Same for similar cases as well
| @@ -1,9 +0,0 @@ | |||
| [tool.isort] | |||
There was a problem hiding this comment.
This should not be deleted too 😅
|
If you are unsure how this will be done, then feel free to ask 😄 |
|
@RiddhiAthreya are you working on this? |
|
I will close this PR and unassign due to lack of response. |
Description
Made changes to the HTTP error codes being returned according to what's discussed in the issue. I have also made the appropriate changes in the swagger documentation.
Fixes #634
Type of Change:
Code/Quality Assurance Only
How Has This Been Tested?
Checklist:
Code/Quality Assurance Only