Enhancement : Require mentor's approval for task completion

[RiddhiAthreya]

Description

Task has got new property requires_approval: [bool]. If it's set to True during creation, task becomes "restricted" - i.e only mentor can mark it as done/completed. When mentee tries to mark it as done, he get's 401 Unauthorized.

Fixes #278

Type of Change:

• Code

Code/Quality Assurance Only

• This change requires a documentation update (software upgrade on readme file)
• New feature (non-breaking change which adds functionality pre-approved by mentors)

How Has This Been Tested?

When a mentee tries to update a task which has requires_approval set to True

creating a task with required_approval set to True

When mentor tries to update a task which has requires_approval set to True

Checklist:

• My PR follows the style guidelines of this project
• I have performed a self-review of my own code or materials
• I have commented my code or provided relevant documentation, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• Update Postman API at /docs folder
• Update Swagger documentation and the exported file at /docs folder
• Update requirements.txt

Code/Quality Assurance Only

• My changes generate no new warnings
• My PR currently breaks something (fix or feature that would cause existing functionality to not work as expected)
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

[epicadk]

You'll also need to add migrations

[RiddhiAthreya]

@epicadk can you please tell me how to add that?

[epicadk]

@epicadk can you please tell me how to add that?

I believe @mtreacy002 was going to create a doc for this?

[mtreacy002]

You'll also need to add migrations

@epicadk , IMO @RiddhiAthreya doesn't need to write a migration script here since the changes applies to dao object of Task and the logic used inside Task db model. The Task db model itself doesn't get affected with the changes here. I tried running flask db migrate and got the response below.

Let me know if you have a different view on this 😉

[RiddhiAthreya]

@mtreacy002 true , only the task json object has changed, but the task table remains the same 😃

[devkapilbansal]

@RiddhiAthreya I see this will work but how the mentor is going to approve the task??

Also, we need some test cases for this too

[devkapilbansal]

Suggested change

	if 'requires_approval' in data.keys():
	requires_approval = data['requires_approval']
	else:
	requires_approval = False
	requires_approval = data.get('requires_approval') or False

[devkapilbansal]

@RiddhiAthreya any updates?