Changed dataset directory to match XDG Base Directory Specification

ankane · Oct 22, 2024 · e54ccf7 · e54ccf7
1 parent ea86eff
commit e54ccf7
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -25,6 +25,6 @@ jobs:
           bundler-cache: true
       - uses: actions/cache@v4
         with:
-          path: ~/.disco
-          key: disco
+          path: ~/.cache/disco
+          key: disco-v2
       - run: bundle exec rake test
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,6 @@
 ## 0.5.0 (unreleased)
 
+- Changed dataset directory to match XDG Base Directory Specification
 - Dropped support for marshal serialization
 - Dropped support for Ruby < 3.1 and Rails < 7
 

diff --git a/lib/disco/data.rb b/lib/disco/data.rb
@@ -33,9 +33,8 @@ def download_file(fname, origin, file_hash:)
       require "net/http"
       require "tmpdir"
 
-      # TODO handle this better
-      raise "No HOME" unless ENV["HOME"]
-      dest = "#{ENV["HOME"]}/.disco/#{fname}"
+      cache_home = ENV["XDG_CACHE_HOME"] || "#{ENV.fetch("HOME")}/.cache"
+      dest = "#{cache_home}/disco/#{fname}"
       FileUtils.mkdir_p(File.dirname(dest))
 
       return dest if File.exist?(dest)