Skip to content

Commit

Permalink
improvement: better 'strings' message for maintainers
Browse files Browse the repository at this point in the history
We had a few times where the process was not followed correctly

Improving the message should reduce the chance of this happening again

Additional links further streamline the process for
those who do not need the knowledge transfer

Test results:

https://redirect.github.com/david-allison/Anki-Android/issues/42#issuecomment-2381427055

Fixes 16980

Note: "PR" URL was changed in Issue 15887

```diff
- https://github.com/ankidroid/Anki-Android/pulls/app%2Fgithub-actions
+ https://github.com/ankidroid/Anki-Android/pulls/mikehardy-machineaccount
```
  • Loading branch information
david-allison committed Sep 30, 2024
1 parent fd461f2 commit fddf0b8
Showing 1 changed file with 6 additions and 7 deletions.
13 changes: 6 additions & 7 deletions .github/workflows/label.yml
Original file line number Diff line number Diff line change
Expand Up @@ -125,13 +125,12 @@ jobs:
owner: context.repo.owner,
repo: context.repo.repo,
issue_number: context.issue.number,
body: `Message to maintainers, this PR contains strings changes.
1. Before merging this PR, it is best to run the "Sync Translations" GitHub action, then make and merge a PR from the i18n_sync branch to get translations cleaned out.
2. Then merge this PR, and immediately do another translation PR so the huge change made by this PR's key changes are all by themselves.
Read more about updating strings on the wiki,
- [localization-administration](https://github.com/ankidroid/Anki-Android/wiki/Development-Guide#localization-administration)
- [download-localized-strings](https://github.com/ankidroid/Anki-Android/wiki/Development-Guide#download-localized-strings)`
body: `> [!IMPORTANT]
> **Maintainers**: This PR contains https://github.com/ankidroid/Anki-Android/labels/Strings changes
1. [Sync Translations](https://github.com/ankidroid/Anki-Android/actions/workflows/sync_translations.yml) before merging this PR and wait for the action to complete
2. Review and merge the [auto-generated PR](https://github.com/ankidroid/Anki-Android/pulls/mikehardy-machineaccount) in order to sync all user-submitted translations
3. [Sync Translations again](https://github.com/ankidroid/Anki-Android/actions/workflows/sync_translations.yml) and merge the [PR](https://github.com/ankidroid/Anki-Android/pulls/mikehardy-machineaccount) so the huge automated string changes caused by merging this PR are by themselves and easy to review`
})
}
Expand Down

0 comments on commit fddf0b8

Please sign in to comment.