-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JS Addons] Addon storage class for handling addons related file/folder functions #11090
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
As this is a refactoring, let me know if you want to move these comment to follow-ups
AnkiDroid/src/main/java/com/ichi2/anki/jsaddons/AddonStorage.kt
Outdated
Show resolved
Hide resolved
AnkiDroid/src/main/java/com/ichi2/anki/jsaddons/AddonStorage.kt
Outdated
Show resolved
Hide resolved
@david-allison I think this one is on you for a re-look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't feel my comments from the previous round have been addressed
I will update the PR later. |
Hello 👋, this PR has been opened for more than 2 months with no activity on it. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 7 days until this gets closed automatically |
Pinning this open - it will happen... |
The addons feature is in progress. I have created a discussion on https://forums.ankiweb.net for better cross platform addons support. Also to learn/understand more about backend and addons support, I started creating feature for Anki which will be available to Anki Ecosystem. |
Pull Request template
Purpose / Description
Handle addons related file/folder functions in a centralized class
AddonStorage
.Fixes
Fixes
Approach
AddonStorage
and implement possibly used methodsAddonStorage
How Has This Been Tested?
Implemented unit test
Learning (optional, can help others)
Describe the research stage
Links to blog posts, patterns, libraries or addons used to solve this problem
Checklist
Please, go through these checks before submitting the PR.
if
statements)