Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JS Addons] Addon storage class for handling addons related file/folder functions #11090

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

krmanik
Copy link
Member

@krmanik krmanik commented Apr 25, 2022

Pull Request template

Purpose / Description

Handle addons related file/folder functions in a centralized class AddonStorage.

Fixes

Fixes

Approach

  1. Create new class AddonStorage and implement possibly used methods
  2. Move methods for addons related file/folder to AddonStorage

How Has This Been Tested?

Implemented unit test

Learning (optional, can help others)

Describe the research stage

Links to blog posts, patterns, libraries or addons used to solve this problem

Checklist

Please, go through these checks before submitting the PR.

  • You have not changed whitespace unnecessarily (it makes diffs hard to read)
  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • Your code follows the style of the project (e.g. never omit braces in if statements)
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

Copy link
Member

@david-allison david-allison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

As this is a refactoring, let me know if you want to move these comment to follow-ups

@mikehardy
Copy link
Member

@david-allison I think this one is on you for a re-look?

Copy link
Member

@david-allison david-allison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't feel my comments from the previous round have been addressed

@mikehardy mikehardy added the Needs Author Reply Waiting for a reply from the original author label May 10, 2022
@mikehardy mikehardy marked this pull request as draft May 10, 2022 20:01
@krmanik
Copy link
Member Author

krmanik commented May 11, 2022

I will update the PR later.

@krmanik krmanik marked this pull request as ready for review June 2, 2022 07:10
@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2022

Hello 👋, this PR has been opened for more than 2 months with no activity on it. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 7 days until this gets closed automatically

@github-actions github-actions bot added the Stale label Aug 1, 2022
@mikehardy
Copy link
Member

Pinning this open - it will happen...

@mikehardy mikehardy added Keep Open avoids the stale bot and removed Stale labels Aug 1, 2022
@krmanik
Copy link
Member Author

krmanik commented Aug 2, 2022

The addons feature is in progress. I have created a discussion on https://forums.ankiweb.net for better cross platform addons support.
https://forums.ankiweb.net/t/ideas-features-cross-platform-js-addons-support-using-rust-backend-and-svelte-frontend/21172?u=krmanik

Also to learn/understand more about backend and addons support, I started creating feature for Anki which will be available to Anki Ecosystem.
krmanik/anki#1

@david-allison david-allison removed their assignment Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Has Conflicts Keep Open avoids the stale bot Needs Author Reply Waiting for a reply from the original author
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants