Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump org.jlleitschuh.gradle.ktlint from 11.6.1 to 12.0.2 #14870

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 4, 2023

Bumps org.jlleitschuh.gradle.ktlint from 11.6.1 to 12.0.2.

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added the dependencies used for automated dependency PRs label Dec 4, 2023
Copy link
Member

@david-allison david-allison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@david-allison david-allison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Editorconfig property 'ktlint_disabled_rules' is obsolete and is not used by KtLint starting from version 0.49. Remove the property from all '.editorconfig' files.

KtLint found code style violations. Please see the following reports:

@david-allison david-allison added Needs Author Reply Waiting for a reply from the original author Help Wanted Requesting Pull Requests from volunteers labels Dec 4, 2023
@mikehardy
Copy link
Member

I fixed quite a few of these and have it running pretty well in general.

It still needs a bit more manual fixing and this is a good first issue because if done well you'll learn:

  • how to use the gh ("Github Command Line Utility" search it, learn about it, install it) utility to check out an upstream PR
  • you'll learn how to manually examine workflows and run the same check that is failing (hint, check the gradle targets run here to see what needs to pass for this to be passing all lint checks)
  • you'll learn how to selectively suppress lint warnings after finding their real rule name (hint, look at my manual fix commit here to see some examples, read the lint report output files to get other names as needed)
  • you'll learn how to use git push --force-with-lease to push your changes to the branch once you have it working

Copy link
Contributor Author

dependabot bot commented on behalf of github Dec 12, 2023

A newer version of org.jlleitschuh.gradle.ktlint exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

@mikehardy
Copy link
Member

https://github.com/JLLeitschuh/ktlint-gradle/blob/main/CHANGELOG.md 12.0.3 doesn't look too major, easily merged into first commit via git rebase whenever I or anyone that has time takes a look

Base automatically changed from dependency-updates to main December 17, 2023 00:04
dependabot bot and others added 5 commits December 22, 2023 10:36
Bumps org.jlleitschuh.gradle.ktlint from 11.6.1 to 12.0.2.

---
updated-dependencies:
- dependency-name: org.jlleitschuh.gradle.ktlint
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
which is a bad practice really, but I'm still learning how to drive the
linter via suppression etc
@mikehardy mikehardy force-pushed the dependabot/gradle/dependency-updates/org.jlleitschuh.gradle.ktlint-12.0.2 branch from cec9aba to 05b4c94 Compare December 22, 2023 16:58
Copy link
Contributor

Hello 👋, this PR has had no activity for more than 2 weeks and needs a reply from the author. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 7 days until this gets closed automatically

@github-actions github-actions bot added the Stale label Jan 18, 2024
@github-actions github-actions bot closed this Jan 25, 2024
Copy link
Contributor Author

dependabot bot commented on behalf of github Jan 25, 2024

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/gradle/dependency-updates/org.jlleitschuh.gradle.ktlint-12.0.2 branch January 25, 2024 16:39
@david-allison david-allison removed Stale Needs Author Reply Waiting for a reply from the original author labels Jan 26, 2024
@david-allison david-allison restored the dependabot/gradle/dependency-updates/org.jlleitschuh.gradle.ktlint-12.0.2 branch January 26, 2024 01:58
@david-allison david-allison reopened this Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies used for automated dependency PRs Good First Issue! Has Conflicts Help Wanted Requesting Pull Requests from volunteers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants