Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GSoC'24] Add NoteEditor to CardBrowser #16764

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Commits on Sep 1, 2024

  1. attach NoteEditor to CardBrowser

    On xlarge screen, display the NoteEditor  on the trailing side of the CardBrowser
    
    This commit introduces a new view, cardbrowser.xml, that contains the card browser (implemented in card_browser.xml) and the note_editor  on xlarge screen.
    SanjaySargam committed Sep 1, 2024
    Configuration menu
    Copy the full SHA
    4462da9 View commit details
    Browse the repository at this point in the history
  2. combine noteeditor menu into cardbrowser menu

    This commit ensures that NoteEditor menu will be visible in CardBroswer
    activity
    SanjaySargam committed Sep 1, 2024
    Configuration menu
    Copy the full SHA
    5f5f841 View commit details
    Browse the repository at this point in the history
  3. hide fragment when deck is empty

    This commit ensure that NoteEditor frame will be hide is the deck is
    empty
    SanjaySargam committed Sep 1, 2024
    Configuration menu
    Copy the full SHA
    df88953 View commit details
    Browse the repository at this point in the history
  4. loadNoteEditor when adding note

    This commit ensures that when adding note from cardbrowser it will load
    note editor on trailing side instead of launching NoteEditor on new
    screen
    SanjaySargam committed Sep 1, 2024
    Configuration menu
    Copy the full SHA
    06d2403 View commit details
    Browse the repository at this point in the history
  5. highlight selected card

    This commit ensures that the selected card should be highlighted on large screens only. By default first card should be highlighted
    SanjaySargam committed Sep 1, 2024
    Configuration menu
    Copy the full SHA
    9cccf86 View commit details
    Browse the repository at this point in the history
  6. show save dialog if there are unsaved changes

    Prompt users to save or discard changes dialog if there is unsaved changes in NoteEditor before moving to another note, preventing accidental data loss.
    SanjaySargam committed Sep 1, 2024
    Configuration menu
    Copy the full SHA
    a027b8c View commit details
    Browse the repository at this point in the history