fix: keep the format of imported images and remove 1MB limit

[criticalAY]

Purpose / Description

Gif was compressed and renamed with jpg extension this PR fixes the issue

Fixes

• Fixes [BUG]: Can't add GIF image #16967
• Fixes Regression: all images imported from the gallery are converted to JPEG and compressed #17020
• Fixes Remove image import arbitrary limit of 1MB #17030

How Has This Been Tested?

Tested on Google emulator API 35

Checklist

Please, go through these checks before submitting the PR.

• You have a descriptive commit message with a short title (first line, max 50 chars).
• You have commented your code, particularly in hard-to-understand areas
• You have performed a self-review of your own code
• UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
• UI Changes: You have tested your change using the Google Accessibility Scanner

[BrayanDSO]

The issue also applies to PNGs, Animated PNGs, WebPs, BMPs, AVIFs, and any format that isn't a JPG file.

It was introduced in #16798 when all the files started being converted to JPGs for no explicit reason.

Why the change from just importing the file as is? This only complicates things and create issues. Files shouldn't be compressed or converted without any warn

[criticalAY]

We only allow max 1 MB image size, camera images are greater than that on physical devices, so I placed it to compress the images by default, for images that are static it should not matter?

[criticalAY]

Now the compression won't take place by default but if the image is over 1MB then there will be an option to compress or crop it when user tries to save it, otherwise the original name and extension will be retained

[BrayanDSO]

for images that are static it should not matter

It breaks transparency, metadata, quality and makes it a lossy image, so it matters a lot.

[BrayanDSO]

Given #17030, you can remove the 1MB limit and the compressing option in this PR

[BrayanDSO]

LGTM

[mikehardy]

This is too far. A feature request from long ago when camera images were only 3MB was that a user would see that an image was large and have the option to crop and/or compress it --> #5629

This PR is the equivalent of "The feature you requested is now mandatory" which is not the way to go.

We should not compress all the time, no. But we should not remove the notice to users that the image is really large and they might consider cropping/compressing it.

[mikehardy]

Note that there is a 100MB per file limit, so there is a limit, even if it is quite large:

https://faqs.ankiweb.net/are-there-limits-on-file-sizes-on-ankiweb.html

At the moment there are no limits on the size of your media, although the size of individual media files is limited to 100MB

[criticalAY]

@mikehardy waiting for your input

[mikehardy]

I'm okay with this in general

I left a nitpick + constructive suggestion on the comment related to the limit as it was outdated size and didn't have a reference to upstream source

I believe all these commits should be squashed and re-pushed as a single commit, since the code involved flaps from deleted to not deleted between commits, it only made sense to review as a single commit, should only be merged as a single commit

If the comment is updated and it's a single commit, I'm good with a merge

[mikehardy]

LGTM - thanks for plowing through this one

[github-actions]

Maintainers: Please Sync Translations to produce a commit with only the automated changes from this PR.

Read more about updating strings on the wiki,

• localization-administration
• download-localized-strings