Menu handled by DeckPicker instead of StudyOptionsFragment

[SanjaySargam]

Purpose / Description

DeckPicker should handle menu responsibility instead of StudyOptionsFramgment (Tablet)
I reverted some changes from PR #16425

• [GSoC'24] Refactor DeckPicker to Single Menu Layout #16425

Fixes

• Fixes DeckPicker should handle menu responsibility instead of StudyOptionsFramgment (Tablet) #17077

How Has This Been Tested?

Emulator

deckpicker_menu.mp4

Checklist

Please, go through these checks before submitting the PR.

• You have a descriptive commit message with a short title (first line, max 50 chars).
• You have commented your code, particularly in hard-to-understand areas
• You have performed a self-review of your own code
• UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
• UI Changes: You have tested your change using the Google Accessibility Scanner

[david-allison]

The following should not be visible if the collection is empty [fragment is invisible]:

• Rename Deck
• Delete Deck
• Custom Study
• Deck Options (I think)
• Export (unsure, but seems sensible)
• Search Decks (🪲 I believe this should only be shown if 10 decks are in the collection)

  • Anki-Android/AnkiDroid/src/main/java/com/ichi2/anki/DeckPicker.kt

    Line 977 in 650697d

    val searchIcon = decks.count() >= 10

A unit test, or @NeedsTest should be added for these cases

[github-actions]

Hello 👋, this PR has had no activity for more than 2 weeks and needs a reply from the author. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 7 days until this gets closed automatically

[github-actions]

Hello 👋, this PR has had no activity for more than 2 weeks and needs a reply from the author. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 7 days until this gets closed automatically

[david-allison]

• I believe: superseded by Fix study options related menus #17314