-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improvement(lint): 'TranslationTypo' - link to Crowdin #17164
Conversation
* Fix constant names * define `Element.reportIssue`
f7d4a33
to
abf3710
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fantastic!
Left some nitpicks don't consider them blocking.
lint-rules/src/test/java/com/ichi2/anki/lint/rules/TranslationTypoTest.kt
Outdated
Show resolved
Hide resolved
lint-rules/src/test/java/com/ichi2/anki/lint/utils/CrowdinTest.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should speed up the "crowdin fix cycle" a lot, very cool
Hopefully all the embedded mapping logic (upstream file numbers, URL structure, language code mapping and stuff) is stable so this doesn't need much upkeep. If that bears out in the future then this is magic
lukstbit approved but with some non-blocking comments - I don't have anything to add to those so marked as "good to merge" but waiting for feedback |
abf3710
to
ac05887
Compare
Aims to save time when maintainers are performing translation syncs Sample link: https://crowdin.com/editor/ankidroid/7290/en-af#q=create_subdeck
ac05887
to
b8e5208
Compare
Purpose / Description
A discussion on #17160 prompted the fact that we can save time by linking directly to Crowdin if errors occur
Sample link: https://crowdin.com/editor/ankidroid/7290/en-af#q=create_subdeck
Approach
01-core.xml
to7290
zh-rCN
tozhcn
#search_string
in the URL fragment worksHow Has This Been Tested?
Manual/unit tests
Checklist