Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement(lint): 'TranslationTypo' - link to Crowdin #17164

Merged
merged 2 commits into from
Sep 30, 2024

Conversation

david-allison
Copy link
Member

@david-allison david-allison commented Sep 30, 2024

Purpose / Description

A discussion on #17160 prompted the fact that we can save time by linking directly to Crowdin if errors occur

Sample link: https://crowdin.com/editor/ankidroid/7290/en-af#q=create_subdeck

Approach

  • obtain a 'file' on Crowdin:
    • map from 01-core.xml to 7290
    • map languages: zh-rCN to zhcn
  • query the string in the file: #search_string in the URL fragment works

How Has This Been Tested?

Manual/unit tests

Checklist

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

* Fix constant names
* define `Element.reportIssue`
Copy link
Member

@lukstbit lukstbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fantastic!
Left some nitpicks don't consider them blocking.

tools/localization/src/update.ts Outdated Show resolved Hide resolved
@lukstbit lukstbit added Needs Second Approval Has one approval, one more approval to merge and removed Needs Review labels Sep 30, 2024
Copy link
Member

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should speed up the "crowdin fix cycle" a lot, very cool

Hopefully all the embedded mapping logic (upstream file numbers, URL structure, language code mapping and stuff) is stable so this doesn't need much upkeep. If that bears out in the future then this is magic

@mikehardy mikehardy added Needs Author Reply Waiting for a reply from the original author Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Second Approval Has one approval, one more approval to merge labels Sep 30, 2024
@mikehardy
Copy link
Member

lukstbit approved but with some non-blocking comments - I don't have anything to add to those so marked as "good to merge" but waiting for feedback

@david-allison david-allison added Needs reviewer reply Waiting for a reply from another reviewer and removed Needs Author Reply Waiting for a reply from the original author labels Sep 30, 2024
Aims to save time when maintainers are performing
translation syncs

Sample link: https://crowdin.com/editor/ankidroid/7290/en-af#q=create_subdeck
@lukstbit lukstbit removed the Needs reviewer reply Waiting for a reply from another reviewer label Sep 30, 2024
@lukstbit lukstbit added this pull request to the merge queue Sep 30, 2024
Merged via the queue into ankidroid:main with commit ad84757 Sep 30, 2024
9 checks passed
@github-actions github-actions bot added this to the 2.19 release milestone Sep 30, 2024
@github-actions github-actions bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Sep 30, 2024
@david-allison david-allison deleted the crowdin-link-2 branch September 30, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants