Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint: better link to Crowdin #17169

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

david-allison
Copy link
Member

A url was added in ad84757

The URL is the most important aspect, but it's inconveniently placed due to the line length

So put it on a newline

- values-bn/01-core.xml:124: Error: should be 'JavaScript'; https://crowdin.com/editor/ankidroid/7290/en-bn#q=create_subdeck [TranslationTypo from com.ichi2.anki:lint-rules]
+ values-bn/01-core.xml:124: Error: should be 'JavaScript'
+ https://crowdin.com/editor/ankidroid/7290/en-bn#q=create_subdeck [TranslationTypo from com.ichi2.anki:lint-rules]

Checklist

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

A Crowdin url was added in ad84757

The URL is the most important aspect, but it's inconveniently placed due
to the line length

So put it on a newline

```diff
- values-bn/01-core.xml:124: Error: should be 'JavaScript'; https://crowdin.com/editor/ankidroid/7290/en-bn#q=create_subdeck [TranslationTypo from com.ichi2.anki:lint-rules]
+ values-bn/01-core.xml:124: Error: should be 'JavaScript'
+ https://crowdin.com/editor/ankidroid/7290/en-bn#q=create_subdeck [TranslationTypo from com.ichi2.anki:lint-rules]
```
Copy link
Member

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚂

@mikehardy mikehardy added this pull request to the merge queue Sep 30, 2024
@mikehardy mikehardy added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Priority-Low Needs Review labels Sep 30, 2024
Merged via the queue into ankidroid:main with commit 728ead7 Sep 30, 2024
9 checks passed
@github-actions github-actions bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Sep 30, 2024
@github-actions github-actions bot added this to the 2.19 release milestone Sep 30, 2024
@david-allison david-allison deleted the improve-crowdin-link branch September 30, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants