Fix notetype name being reverted when going to CardTemplateEditor #17173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikehardy
added
Needs Second Approval
david-allison
approved these changes
Oct 2, 2024
There was a problem hiding this comment.
This implies we're not doing things correctly WRT the Rust backend.
This works as a bandaid, but we should add a task to work through the underlying issue
My comment below is untested, and I strongly suspect this fix is correct
A unit test or @NeedsTest here would be useful, but not necessary
david-allison
added
Needs Author Reply
There's a disconnect between what ManageNoteypes is doing(working with the collection through CollectionManager) and what CardTemplatedEditor is doing(using the previous system with getColUnsafe). This seems to result in CardTemplateEditor "seeing" only the previous name from ManageNotetypes and reverting the name when any change in the template is saved. A call to Notetypes.clearCache() was introduced to remove stale data from Notetypes.
lukstbit
force-pushed
the
fix_notetypeRenaming
branch
from
b146bf0
to
9987768
Compare
lukstbit
removed
the
Needs Author Reply
github-actions
bot
removed
the
Pending Merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose / Description
Due to how CardTemplateEditor accesses the collection it seems it doesn't "see" the renames done in ManageNotetypes so when it saves any changes to the template it also saves the last name it "saw". I just called load() on the collection to initialize again the components, especially Notetypes. This should be ok, I don't think there are other side effects on calling load().
There's a warning for worker method being called on the main thread but I think it's safe as that method just initializes again several objects, it doesn't seem to do anything heavy.
We should probably move CardTemplateEditor to use CollectionManager.
Fixes
How Has This Been Tested?
Ran the tests, manually tried(and failed) to replicate the issue again.
Checklist