Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump androidGradlePlugin from 8.6.1 to 8.7.0 #17181

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 2, 2024

Bumps androidGradlePlugin from 8.6.1 to 8.7.0.
Updates com.android.application from 8.6.1 to 8.7.0

Updates com.android.library from 8.6.1 to 8.7.0

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies used for automated dependency PRs label Oct 2, 2024
@david-allison david-allison self-assigned this Oct 2, 2024
Copy link
Member

@david-allison david-allison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI Failure.

https://developer.android.com/build/releases/gradle-plugin#android-gradle-plugin-8.7.0

Fixes:

Issue #364261817
"False positive" WrongConstant when using PackageManager.ResolveInfoFlags.of with Kotlin

@david-allison
Copy link
Member

Requires Android Studio Ladybug, which doesn't auto-update :/

@mikehardy
Copy link
Member

Requires Android Studio Ladybug, which doesn't auto-update :/

Mine auto-updated just fine ? (windows x 1, and macOS x 3)

@david-allison david-allison force-pushed the dependabot/gradle/dependency-updates/androidGradlePlugin-8.7.0 branch from dc86409 to 38a1f55 Compare October 2, 2024 15:07
@david-allison david-allison removed their assignment Oct 2, 2024
@david-allison
Copy link
Member

Couldn't remove the following line.

I'll wait until the next AGP release before going back to Google

    open = true, // HACK: AGP 8.6.1 broke .toLong(): https://issuetracker.google.com/issues/367752734

Copy link
Member

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did they actually fix the Lint thing as well? could perhaps remove the workaround you had to hack in there edit: I see you tried, sigh 😆

additionally - I don't see a need for a new file+extension for a thing used once, doesn't meet the bar for abstraction imho

Fixes NewApi warning on `removeLast()`

https://developer.android.com/about/versions/15/behavior-changes-15?hl=en#:~:text=The%20new%20SequencedCollection,has%20been%20disabled.

Bumps `androidGradlePlugin` from 8.6.1 to 8.7.0.

Updates `com.android.application` from 8.6.1 to 8.7.0

Updates `com.android.library` from 8.6.1 to 8.7.0

---
updated-dependencies:
- dependency-name: com.android.application
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: com.android.library
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@david-allison david-allison force-pushed the dependabot/gradle/dependency-updates/androidGradlePlugin-8.7.0 branch from 38a1f55 to cf8f911 Compare October 2, 2024 15:25
Copy link
Member

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

KISS principle at work :-)
I was on the fence on how the NoSuchElementException was handled but the previous code was liable to throw it as well I believe and I suppose it will just bubble up or (more likely) it's not possible in this context

either way I don't believe this transformation to the un-shadowed API is a semantic change, so it looks perfect and KISS

@mikehardy mikehardy merged commit 61047fa into dependency-updates Oct 2, 2024
17 checks passed
@dependabot dependabot bot deleted the dependabot/gradle/dependency-updates/androidGradlePlugin-8.7.0 branch October 2, 2024 16:07
@github-actions github-actions bot added this to the 2.19 release milestone Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies used for automated dependency PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants