Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix controls layout in landscape #17188

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Conversation

RobozinhoD
Copy link
Contributor

the warning wasn't well positioned

Purpose / Description

Describe the problem or feature and motivation

Fixes

Approach

Position the warning correctly. The picker can get smaller if there is a warning. The only way that I see to fix that is to put the spinner aligned with the buttons or make the picker smaller, but I wanted to just fix the issue for now.

How Has This Been Tested?

a.webm

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

the warning wasn't well positioned
Copy link
Member

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@mikehardy mikehardy added this pull request to the merge queue Oct 4, 2024
Merged via the queue into ankidroid:main with commit f444f69 Oct 4, 2024
12 checks passed
@github-actions github-actions bot added this to the 2.19 release milestone Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: The layout of the Gesture Picker screen is not rendering properly when viewed in landscape mode.
2 participants