Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Android Studio lint errors in AudioRecordingController.kt #17195

Conversation

benwicks
Copy link
Contributor

@benwicks benwicks commented Oct 3, 2024

Purpose / Description

There were 2 Android Lint errors and 1 warning in AudioRecordingController.kt that are fixed in this PR.

Fixes

Approach

I just picked the first errors after a code inspection and fixed the warning in the file too.

How Has This Been Tested?

No testing is necessary for the changes to parameter ordering.
I added the exception parameter to the one Timber.d call where it was missing. I believe this call will be a no-op for non-debug builds.

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

Copy link
Member

@david-allison david-allison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff, cheers!

@david-allison david-allison added the Needs Second Approval Has one approval, one more approval to merge label Oct 4, 2024
Copy link
Member

@lukstbit lukstbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There were 2 Android Lint errors and 1 warning in AudioRecordingController.kt

These were not highlighted as issues in the IDE. Still approving the changes as the code now uses the proper Timber logging methods where the throwable is used.

@lukstbit lukstbit added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Second Approval Has one approval, one more approval to merge labels Oct 4, 2024
@lukstbit lukstbit added this pull request to the merge queue Oct 4, 2024
Merged via the queue into ankidroid:main with commit 1cdd647 Oct 4, 2024
12 checks passed
@github-actions github-actions bot added this to the 2.19 release milestone Oct 4, 2024
@github-actions github-actions bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Oct 4, 2024
@benwicks benwicks deleted the fix-android-studio-lint-errors-in-AudioRecordingController branch October 4, 2024 13:47
@benwicks
Copy link
Contributor Author

benwicks commented Oct 4, 2024

Thanks for helping me get started here! Is it possible to get the hacktoberfest-accepted label on this please?

@lukstbit lukstbit added the hacktoberfest-accepted Accepted for Hacktoberfest label Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Accepted for Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants