Code cleaning: using enum where possible #17352
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arthur-Milchior
force-pushed
the
else
branch
2 times, most recently
from
8e1aabe
to
eb5a248
Compare
|
Could you split this into a few smaller PRs (~2/300 lines each)? This isn't going to be easy to review otherwise, especially as it's low priority. The first commit in the series uses single variable names for a class (
I believe it was an AOSP standard for many years. |
david-allison
added
the
Needs Author Reply
Arthur-Milchior
force-pushed
the
else
branch
from
eb5a248
to
04e228a
Compare
|
@david-allison done |
|
Tests fail on this one |
When `when` is used on an enum, the `else ->` can always be transformed into a complete enumeration of the enum's entries. This ensure that each time a new entry is added, there is a warning and the developer must decide whether or not a change is needed. While the `else` may hide some required change. So, for the sake of future developement, I removed `else ->` when it makes sense. I should note that I kept some `else ->` when the `when` consider only a very small part of all possible enum value, in order to reduce the size of the code.
Arthur-Milchior
force-pushed
the
else
branch
from
04e228a
to
4896740
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR (quite simplified compared to first version), replace some else -> by an exhaustive constant list. This will ensure that if more enum are added, we won't forget to consider all enums