Some enum #17435
Some enum #17435
Conversation
That allows to remove a else -> and improve typing.
Arthur-Milchior
force-pushed
the
some_enum
branch
from
6b5acb0
to
33a3ae4
Compare
There was a problem hiding this comment.
Note: both of these classes are planned to be deleted.
Signal is fine. Good change
I don't like Caller from an architecture POV, but I don't feel strongly here.
I do want to stop using implicit enum ordinals, and that's what I'll request changes on: that makes the order of the enums a source of bugs.
| ADD_IMAGE, | ||
| INSTANT_NOTE_EDITOR; | ||
| companion object { | ||
| fun Int.toCaller() = Caller.entries[this] |
There was a problem hiding this comment.
This is a recipe for disaster, keep the enum ints explicit
This now throws on an unexpected value
There was a problem hiding this comment.
If this were expected to survive, I'd prefer to see an acra report on unexpected value. Because that's unexpected, and I'd prefer to know this occurs. Because that means that we probably don't do what we expect to do when the collection is loaded
david-allison
added
the
Needs Author Reply
Improve typing
Arthur-Milchior
force-pushed
the
some_enum
branch
from
33a3ae4
to
0fc1957
Compare
Those commits add some enum for the sake of code clarity