Implemented some libanki TODOs #17442
Open
+38
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrayanDSO
approved these changes
Nov 14, 2024
BrayanDSO
added
the
Needs Second Approval
david-allison
approved these changes
Nov 16, 2024
| private fun addDeck(deck: Deck): OpChangesWithId { | ||
| TODO() | ||
| @Suppress("unused") | ||
| fun addDeck(deck: anki.decks.Deck): OpChangesWithId { |
There was a problem hiding this comment.
This is the only somewhat questionable one:
Do we want to continue using Deck, or move to the upstream Protobuf
For now, this is the easiest course of action
There was a problem hiding this comment.
I think that this one should be equal to libanki and that we can create another util or extension method for Deck
david-allison
added
squash-merge
|
@RobozinhoD Thanks! Could you squash this and it'll be good to go |
libanki updateDict() libanki update() libanki have() libanki addNormalDeckWithName() libanki addDeck()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose / Description
I tried to find some TODO in the project and fixed these in libanki. I hope it helps
Approach
Followed upstream's implementation
https://github.com/ankitects/anki/blob/edf59c2bb2a3dad36115af7518cdcbb3ee397089/pylib/anki/decks.py
How Has This Been Tested?
I don't know how to test it
Checklist
Please, go through these checks before submitting the PR.