Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't Exclude Suspended Cards from Retreivability Graph #3665

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Don't Exclude Suspended Cards from Retreivability Graph #3665

wants to merge 2 commits into from

Conversation

brishtibheja
Copy link
Contributor

@brishtibheja brishtibheja commented Dec 24, 2024 •
edited
Loading

@user1823
Copy link
Contributor

user1823 commented Dec 24, 2024 •
edited
Loading

Only the following part needs to be removed:

use crate::card::CardQueue;

            if card.queue == CardQueue::Suspended {
                continue;
            }

Other changes are not related.

@brishtibheja
Copy link
Contributor Author

Does it look good now?

user1823
user1823 approved these changes Dec 24, 2024
View reviewed changes
Copy link
Contributor

@user1823 user1823 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@brishtibheja brishtibheja changed the title Revert "Fix/skip suspended cards in graphs context retrievability" Don't Exclude Suspended Cards from Retreivability Graph Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@user1823 user1823 user1823 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brishtibheja @user1823