Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simulator legend tooltip #3676

Merged
merged 4 commits into from
Jan 9, 2025
Merged

Conversation

Luc-Mcgrady
Copy link
Contributor

@brishtibheja
Copy link
Contributor

Thanks Luc! Nitpicking here: shouldn't the time stats unit also have /day in it? In this case, mins/day.

@Luc-Mcgrady
Copy link
Contributor Author

Getting the i18n of /day working with the seconds/minutes/hours seemed like a huge pain.
I'm assuming here I can't just do something like

timeSpan(count) + // {count} seconds|minutes|hours
tr.perDay() // /day

And that we'd need 3 more translations of

statisticsElapsedTimeSecondsPerDay
statisticsElapsedTimeMinutesPerDay
statisticsElapsedTimeHoursPerDay

@dae
Copy link
Member

dae commented Jan 9, 2025

You can do something like

statistics-per-day = {time}/day

That allows translators to reorder the words if necessary, eg their language equiv. of 'per day: {time}', etc.

@dae dae merged commit 1651472 into ankitects:main Jan 9, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants