Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some unit tests #3678

Merged
merged 6 commits into from
Jan 4, 2025
Merged

Add some unit tests #3678

Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
bc91f31
Add some unit tests
user1823 Dec 28, 2024
f2463c5
Format
user1823 Dec 28, 2024
eaa8ba6
Update params.rs
user1823 Dec 28, 2024
fbcba28
Update params.rs
user1823 Jan 1, 2025
0b8ef7b
Improve naming
user1823 Jan 2, 2025
f25029e
Fix typo
user1823 Jan 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
71 changes: 70 additions & 1 deletion rslib/src/scheduler/fsrs/params.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -545,11 +545,12 @@ pub(crate) mod tests {

#[test]
fn card_reset_drops_all_previous_history() {
// If Reset comes in between two Learn entries, only the ones after the Reset
// are used.
assert_eq!(
convert(
&[
revlog(RevlogReviewKind::Learning, 10),
revlog(RevlogReviewKind::Review, 9),
RevlogEntry {
ease_factor: 0,
..revlog(RevlogReviewKind::Manual, 7)
Expand All @@ -561,6 +562,58 @@ pub(crate) mod tests {
),
fsrs_items!([review(0), review(4)])
);
// Return None if Reset is the last entry or is followed by only manual entries.
assert_eq!(
convert(
&[
revlog(RevlogReviewKind::Learning, 10),
revlog(RevlogReviewKind::Review, 9),
RevlogEntry {
ease_factor: 0,
..revlog(RevlogReviewKind::Manual, 7)
},
RevlogEntry {
ease_factor: 100,
..revlog(RevlogReviewKind::Manual, 7)
},
],
false,
),
None,
);
// If non-learning user-graded entries are found after Reset, return None during
// training but return the remaining entries during memory state calculation.
assert_eq!(
convert(
&[
revlog(RevlogReviewKind::Learning, 10),
revlog(RevlogReviewKind::Review, 9),
RevlogEntry {
ease_factor: 0,
..revlog(RevlogReviewKind::Manual, 7)
},
revlog(RevlogReviewKind::Review, 1),
revlog(RevlogReviewKind::Relearning, 0),
],
true,
),
None,
);
assert_eq!(
convert(
&[
revlog(RevlogReviewKind::Review, 9),
RevlogEntry {
ease_factor: 0,
..revlog(RevlogReviewKind::Manual, 7)
},
revlog(RevlogReviewKind::Review, 1),
revlog(RevlogReviewKind::Relearning, 0),
],
false,
),
fsrs_items!([review(0), review(1)])
user1823 marked this conversation as resolved.
Show resolved Hide resolved
);
}

#[test]
Expand Down Expand Up @@ -636,4 +689,20 @@ pub(crate) mod tests {
convert(revlogs, false)
);
}

#[test]
fn even_if_no_learning_steps_ignore_reviews_before_during_reviewing() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a naming nitpick:

Suggested change
fn even_if_no_learning_steps_ignore_reviews_before_during_reviewing() {
fn ignore_reviews_before_during_reviewing_even_if_no_learning_steps() {

let revlogs = &[
revlog(RevlogReviewKind::Review, 10),
revlog(RevlogReviewKind::Review, 8),
revlog(RevlogReviewKind::Review, 6),
];
// R | R R
assert_eq!(
convert_ignore_before(revlogs, false, days_ago_ms(9))
.unwrap()
.len(),
2
);
}
}