Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update v3 scheduler section #33
update v3 scheduler section #33
Changes from all commits
570d47f
d77ea2c
a52093e
afc1d17
801e6ba
0c4cdaf
e4952e8
f1a8764
9c51649
5d2eaf8
0256f31
aa61a81
08d5673
72db42d
a95d1d7
168cf8d
bf6b3b3
418a5b6
296debf
83b3ef6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note for future PRs: are changes like this line really improving legibility? They feel more like change for the sake of change, though I'm aware the fact that I'm a native English speaker may be biasing my perceptions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The preposition from felt more natural here. Although, I agree I could've kept the in in there.
As for the word old, I think it comes with a negative connotation oftentimes. Using earlier is neutral and is more clear. One might think, because they downloaded Anki a few months ago, it's probably not "old".