-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Betterify property access, implement ES5 getters and ES6 syntax for objects #41
base: master
Are you sure you want to change the base?
Conversation
…bjects This intentionally reserves generators, because those haven't been implemented in functions yet. It will be easy to add when they are implemented elsewhere, though.
This latest push is still part of a WIP. |
Just realized...this will also fix #22. |
Here's a summary of some of the changes to the syntax:
|
I know this is currently broken, but could I get some ideas on why the If this is any help, the |
Even weirder about this is the fact this is only happening locally. I'm looking into it on my end. |
Never mind about that. It's not broken. I just had to replace my node_modules folder. |
@anko I think this is ready to merge now. |
@anko
Fixes #13, #23, #22.
This intentionally reserves generators, because those haven't been
implemented in functions yet. It will be easy to add when they are
implemented elsewhere, though.
It also is based on @tabatkins' idea of using
:keyword
to refer to symbols rather than simple atoms.Note that this can change depending on the outcome of anko/sexpr-plus#3, as it would allow for a better integration into the syntax level (and also to help decouple the standard library a little). That modification would also, IMHO, be a little less fragile, and it's almost trivial to convert my patch to use that version if implemented. Matter of fact, that would actually simplify it, as I'm checking just types rather than a type and the first character.
And, well, a single quote looks better. 😄 But as it stands, this is a WIP until anko/sexpr-plus#3 is addressed