fix: formatName issue (#1218)

annuaire-entreprises-data-gouv-fr · Sep 26, 2024 · 11e10ea · 11e10ea
1 parent 0d22bdf
commit 11e10ea
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/clients/sirene-insee/siren.ts b/clients/sirene-insee/siren.ts
@@ -11,7 +11,7 @@ import {
 } from '#models/core/types';
 import {
   agregateTripleFields,
-  formatFirstNames,
+  capitalize,
   formatNameFull,
   isEntrepreneurIndividuelFromNatureJuridique,
   Siren,
@@ -215,9 +215,10 @@ const mapToDomainObject = (
 
   // EI names and firstName
   // remove trailing whitespace in case name or firstname is missing
-  const names = `${
-    formatFirstNames(prenomUsuelUniteLegale, '').prenom
-  } ${formatNameFull(nomUniteLegale, nomUsageUniteLegale)}`.trim();
+  const names = `${capitalize(prenomUsuelUniteLegale)} ${formatNameFull(
+    nomUniteLegale,
+    nomUsageUniteLegale
+  )}`.trim();
 
   const defaultUniteLegale = createDefaultUniteLegale(siren);
 

diff --git a/utils/helpers/formatting/formatting.ts b/utils/helpers/formatting/formatting.ts
@@ -350,7 +350,7 @@ export const agregateTripleFields = (
   return field.trim();
 };
 
-export const formatFirstNames = (firstNames: string, separator: string) => {
+export const formatFirstNames = (firstNames: string, separator: ', ' | ' ') => {
   const formatted = (firstNames || '')
     .split(separator)
     .map(capitalize)