Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: split justificatif into /documents and /entreprise and /annonces #1192

Merged
merged 21 commits into from
Sep 17, 2024
Merged

feat: split justificatif into /documents and /entreprise and /annonces #1192

merged 21 commits into from
Sep 17, 2024

Conversation

XavierJp
Copy link
Contributor

@XavierJp XavierJp commented Aug 15, 2024 •
edited
Loading

Todo :

  • raccourcis vers documents
  • Inscrite au RNA
  • Inscrite a XXX , le ...
  • observations ajouter un .
  • resumé dans annonces et observations
  • redirection de justificatif/<siren> vers documents/<siren>
  • Parser les observations sur data.inpi;fr + add metadata warning
  • justif dans la page
  • Proxy refactoring is needed :
    • a route for RNE call
      • returns dirigeants, observations and immatriculation
    • a route for RNE fallback
      • returns immatriculation, observations (no need for dirigeant ?)
  • changelog
  • fallback /dirigeants to API recherche
  • cleaning
  • handle immatriculation error (404 or 5xx from INPI / from recherche)
    • if recherche down or dateInpi = null -> call Proxy
    • proxy must return a clone of immatriculation object
    • if proxy down we get a IAPINotResponding
  • tests

closes #975
closes #828

@XavierJp XavierJp mentioned this pull request Aug 21, 2024
Merged
@XavierJp XavierJp marked this pull request as ready for review August 29, 2024 15:58
@XavierJp
Copy link
Contributor Author

XavierJp commented Aug 29, 2024 •
edited
Loading

@johangirod @HAEKADI sorry for this MASSIVE overhaul. This is not yet finished and lacks some tests. Yet it is ready for review :

  • delete /justificatif page
  • update changelog
  • move immatriculation data to Fiche résumé
image
  • move justificatif PDF to /documents
  • move observations to /annonces
  • revamp the main section
image

HAEKADI
HAEKADI approved these changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@HAEKADI HAEKADI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool 🚀

app/(header-default)/entreprise/[slug]/_components/inscriptions.tsx Outdated Show resolved Hide resolved
data/faq/registre-des-beneficiaires-effectifs.yml Outdated Show resolved Hide resolved
@XavierJp
Copy link
Contributor Author

XavierJp commented Sep 17, 2024 •
edited
Loading

@HAEKADI it is ready. The time has come. As soon as the tests are green, It is all yours to merge.

I believe only you can merge it as you poured so much efforts into this. And once again, amazing work. Congratulations and thanks for all the fish 🐬

@HAEKADI
Copy link
Contributor

HAEKADI commented Sep 17, 2024

LET'S GOOO

@HAEKADI HAEKADI merged commit bbfdfa7 into main Sep 17, 2024
8 checks passed
@HAEKADI HAEKADI deleted the 975-justificatif branch September 17, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HAEKADI HAEKADI HAEKADI approved these changes

@johangirod johangirod Awaiting requested review from johangirod

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@XavierJp @HAEKADI