feat: add data subvention source #1263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmonnier9
force-pushed
the
1241-data-subvention
branch
from
e2a0f24
to
8aa9f72
Compare
|
J'aime beaucoup ! Quelques feedbacks UX :
|
XavierJp
reviewed
Oct 10, 2024
Comment on lines
1
to
14
| slug: data-subvention | ||
| short: Data.Subvention | ||
| site: https://datasubvention.beta.gouv.fr/ | ||
| long: Data.Subvention | ||
| logoType: portrait | ||
| dataSources: | ||
| - label: Data.Subvention | ||
| apiSlug: data-subvention | ||
| data: | ||
| - label: Data.Subvention | ||
| targets: | ||
| - agent | ||
| contact: https://datasubvention.beta.gouv.fr/contact/ | ||
| description: Un outil de consultation pour les agents de l'Etat porté par la DJEPVA et la DINUM pour éclaircir vos décisions et mieux connaître les associations |
There was a problem hiding this comment.
I am wondering wether we create an administration or we use the existing DJEPVA one
There was a problem hiding this comment.
Let's see with the Data.Subvention team ?
Comment on lines
22
to
23
| if (!subventions) return null; | ||
|
|
There was a problem hiding this comment.
Not sure about this. Either the user has the rights to see it and he/she prefer an explanation like : Aucune demande de subvention n’a été trouvée pour cette association.. Or h/she is not agent connected and we could display the <AgentWall /> component
|
rmonnier9
force-pushed
the
1241-data-subvention
branch
from
95c725f
to
a06ccf8
Compare
|
Il faudra penser a provisionner DATA_SUBVENTION_API_KEY @MKCG |
|
Todo
|
Signed-off-by: Xavier Jp <[email protected]>
XavierJp
approved these changes
Oct 14, 2024
|
@rmonnier9 attendons demain pour voir, vu l'incident de prod actuel. |
rmonnier9
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
multiple.references #1241