Apply fixes from brew audit #11
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We install GHC using the binary release directly because installation of GHC via ghcup or via stack in the formula context is not reliable. Specifially the GHC installation with ghcup or stack fails *sometimes* (with about 1/5 frequency) when trying to create a temporary directory within the temporary HOME directory used by the formula build. The GHC installer works reliably when invoked directly from the bindist
In particular we were not specifying a git ref for the stable version the git ref of the `main` branch was always used. This is now fixed by specifying the `revision` field on the juvix git URL.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is mostly formatting fixes suggested by
brew audit.The main fix of substance is that we were not specifying a git ref for the stable version
the git ref of the
mainbranch was always used. This is now fixed by specifying therevisionfield on the juvix git URL.