Mariari/list additions and refactorings #146
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The naming on this is probably bad, I'd assume `head` would return Maybe, and you'd have a headDefault or something for a default head
Partial trait relied upon import Stdlib.Data.String.Base open; which indirectly relies upon list, we loosen the restriction to just rely on the String type itself. This lets us move some functions around to the base module
…-additions-and-refactorings
|
This topic should have a lot of good functions to crib from, I think fori needs to be cleaned up a bit. |
I'm unsure if we can add this to a trait or not
mariari
force-pushed
the
mariari/list-additions-and-refactorings
branch
from
79f5c75
to
51d4d32
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integration branch of all the list refactorings along with many new additional refactors. Currently WIP. Will unamrk as draft when ready