[fix]: Fixed deserialization issues cause by bytes misalignment due t…

…o u64 (as opposed to i128) assumptions.
anoma · Jun 26, 2023 · 9320c6b · 9320c6b
1 parent 64caae7
commit 9320c6b
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/masp_primitives/src/transaction/components/transparent.rs b/masp_primitives/src/transaction/components/transparent.rs
@@ -105,10 +105,10 @@ impl TxIn<Authorized> {
     pub fn read<R: Read>(reader: &mut R) -> io::Result<Self> {
         let asset_type = AssetType::read(reader)?;
         let value = {
-            assert_eq!(core::mem::size_of::<u64>(), 8);
-            let mut tmp = [0u8; core::mem::size_of::<u64>()];
+            assert_eq!(core::mem::size_of::<i128>(), 16);
+            let mut tmp = [0u8; core::mem::size_of::<i128>()];
             reader.read_exact(&mut tmp)?;
-            u64::from_le_bytes(tmp).into()
+            i128::from_le_bytes(tmp).into()
         };
         if value < 0 || value > MAX_MONEY {
             return Err(io::Error::new(
@@ -148,10 +148,10 @@ impl TxOut {
     pub fn read<R: Read>(reader: &mut R) -> io::Result<Self> {
         let asset_type = AssetType::read(reader)?;
         let value = {
-            assert_eq!(core::mem::size_of::<u64>(), 8);
-            let mut tmp = [0u8; core::mem::size_of::<u64>()];
+            assert_eq!(core::mem::size_of::<i128>(), 16);
+            let mut tmp = [0u8; core::mem::size_of::<i128>()];
             reader.read_exact(&mut tmp)?;
-            u64::from_le_bytes(tmp).into()
+            i128::from_le_bytes(tmp).into()
         };
         if value < 0 || value > MAX_MONEY {
             return Err(io::Error::new(