Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checked add and sub for ValueSum #70

Merged
merged 2 commits into from
Jan 30, 2024
Merged

Checked add and sub for ValueSum #70

merged 2 commits into from
Jan 30, 2024

Conversation

grarco
Copy link
Contributor

@grarco grarco commented Jan 29, 2024 •
edited
Loading

Adds checked_sum and checked_sub ops on ValueSum. Tweaked the normal add and sub operations to call the checked variants internally.

@grarco grarco marked this pull request as ready for review January 29, 2024 17:36
@grarco grarco requested a review from murisi January 29, 2024 17:36
murisi
murisi approved these changes Jan 29, 2024
View reviewed changes
Copy link
Contributor

@murisi murisi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one. Looks good to me! Thanks!

@grarco grarco merged commit f24691c into main Jan 30, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@murisi murisi murisi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grarco @murisi