Skip to content

Commit

Permalink
fix: pass correct page in gov pagination
Browse files Browse the repository at this point in the history
  • Loading branch information
mateuszjasiuk committed Jul 9, 2024
1 parent f9a4d2f commit 01ee909
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 17 deletions.
10 changes: 4 additions & 6 deletions webserver/src/dto/governance.rs
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
use serde::{Deserialize, Serialize};
use validator::Validate;

use super::utils::Pagination;

#[derive(Clone, Debug, Serialize, Deserialize)]
#[serde(rename_all = "camelCase")]
pub enum ProposalStatus {
Expand All @@ -23,15 +21,15 @@ pub enum ProposalKind {

#[derive(Clone, Serialize, Deserialize, Validate)]
pub struct ProposalQueryParams {
#[serde(flatten)]
pub pagination: Option<Pagination>,
#[validate(range(min = 1, max = 10000))]
pub page: Option<u64>,
pub status: Option<ProposalStatus>,
pub kind: Option<ProposalKind>,
pub pattern: Option<String>,
}

#[derive(Clone, Serialize, Deserialize, Validate)]
pub struct ProposalVotesQueryparams {
#[serde(flatten)]
pub pagination: Option<Pagination>,
#[validate(range(min = 1, max = 10000))]
pub page: Option<u64>,
}
1 change: 0 additions & 1 deletion webserver/src/dto/mod.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
pub mod governance;
pub mod pos;
pub mod utils;
8 changes: 0 additions & 8 deletions webserver/src/dto/utils.rs

This file was deleted.

4 changes: 2 additions & 2 deletions webserver/src/handler/governance.rs
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ pub async fn get_governance_proposals(
Query(query): Query<ProposalQueryParams>,
State(state): State<CommonState>,
) -> Result<Json<PaginatedResponse<Vec<Proposal>>>, ApiError> {
let page = query.pagination.map(|p| p.page).unwrap_or(1);
let page = query.page.unwrap_or(1);
let (proposals, total_pages, total_items) = state
.gov_service
.find_governance_proposals(
Expand Down Expand Up @@ -57,7 +57,7 @@ pub async fn get_governance_proposal_votes(
Query(query): Query<ProposalVotesQueryparams>,
State(state): State<CommonState>,
) -> Result<Json<PaginatedResponse<Vec<ProposalVote>>>, ApiError> {
let page = query.pagination.map(|p| p.page).unwrap_or(1);
let page = query.page.unwrap_or(1);
let (proposal_votes, total_pages, total_votes) = state
.gov_service
.find_governance_proposal_votes(proposal_id, page)
Expand Down

0 comments on commit 01ee909

Please sign in to comment.