feat/1251: Fetch applications feature flags from registry #1255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jurevans
force-pushed
the
feat/1251-async-feature-flags
branch
3 times, most recently
from
3e8a1ea
to
342c9a3
Compare
jurevans
changed the title
jurevans
force-pushed
the
feat/1251-async-feature-flags
branch
from
342c9a3
to
15d495e
Compare
jurevans
requested review from
pedrorezende,
euharrison,
emccorson and
mateuszjasiuk
jurevans
force-pushed
the
feat/1251-async-feature-flags
branch
from
3a8c753
to
2d0c3fc
Compare
jurevans
force-pushed
the
feat/1251-async-feature-flags
branch
from
2d0c3fc
to
2d6fac3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1251
This PR updates the application features to now be loaded async directly from the registry:
https://github.com/anoma/namada-chain-registry
Example flags to be read:
https://github.com/anoma/namada-chain-registry/blob/b5ac94e0c3e8e091b0668f005d90920fc64b12b1/namadahousefire/chain.json#L14-L21
DEMO
https://namada-interface-dev.netlify.app/staking
namada-dryrun.abaaeaf7b78cb3ac, but it's good to also point to Housefire to test feature states for that as wellTESTING
namadillowithyarn dev:proxy- needed to access Github registry (we need to also test this from Netlfiy, I wonder if CORS with Github is an issue there too...)Claim Stakingshould be enabledhttps://indexer.knowable.run/, reload if necessary, all features should be enabled!