Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore - Bump shared to namada 0.41.0 #948

Merged
merged 1 commit into from
Jul 26, 2024
Merged

chore - Bump shared to namada 0.41.0 #948

merged 1 commit into from
Jul 26, 2024

Conversation

jurevans
Copy link
Collaborator

@jurevans jurevans commented Jul 25, 2024 •
edited
Loading

Update to support Namada v0.41.0 (mainnet release)

  • Bump Namada to v0.41.0
  • Updated args for IBC Transfer
  • some changes to shielded sync - left comments as we can't implement shielded sync the same way now, so this could be a new issue to look into
  • Regenerate docs for packages/types to catch latest changes

@jurevans jurevans self-assigned this Jul 25, 2024
@jurevans jurevans added this to the PoS, Governance milestone Jul 25, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 25, 2024 •
edited
Loading

🚀 Deployed on https://pull-request-948--wallet-development-heliax-dev.netlify.app

@github-actions github-actions bot temporarily deployed to pull request July 25, 2024 13:50 Inactive
@jurevans jurevans changed the title WIP: chore - Bump shared to namada 0.41.0 chore - Bump shared to namada 0.41.0 Jul 25, 2024
@jurevans jurevans marked this pull request as ready for review July 25, 2024 15:12
@github-actions github-actions bot temporarily deployed to pull request July 25, 2024 15:20 Inactive
jurevans
jurevans commented Jul 25, 2024
View reviewed changes
packages/shared/lib/src/sdk/args.rs
Some(v) => Some(IbcShieldingData::try_from_slice(&v)?),
None => None,
};

Copy link
Collaborator Author

@jurevans jurevans Jul 25, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See https://github.com/anoma/namada/blob/9b8252e6c3dd73678c00495b474bb7795a77b6c6/crates/ibc/src/msg.rs#L130-L137

We will need to implement something for MaspTransaction for shielding over IBC. Our schema can just handle the Borsh-serialized bytes, but that will need to be constructed in the interface, this just gets our schema up-to-date for IBC

@github-actions github-actions bot temporarily deployed to pull request July 26, 2024 12:35 Inactive
mateuszjasiuk
mateuszjasiuk approved these changes Jul 26, 2024
View reviewed changes
Copy link
Collaborator

@mateuszjasiuk mateuszjasiuk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested and works nicely! We need to merge this before. Otherwise txs will get rejected

@jurevans jurevans merged commit 958b697 into main Jul 26, 2024
8 checks passed
@jurevans jurevans deleted the chore/bump-namada-0.41.0 branch July 26, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mateuszjasiuk mateuszjasiuk mateuszjasiuk approved these changes

@emccorson emccorson Awaiting requested review from emccorson

Assignees

@jurevans jurevans

Labels
feature Lib: SDK
Projects
None yet
Milestone
Mainnet Release
Development

Successfully merging this pull request may close these issues.
2 participants
@jurevans @mateuszjasiuk