move masp validation from SDK into shielded_token crate

[tzemanovic]

Describe your changes

closes #3101

Indicate on which release or other PRs this topic is based on

0.39.0

Checklist before merging to draft

• I have added a changelog
• Git history is in acceptable state

[grarco]

One minor comment but LGTM!

Ah actually failing unit tests

[tzemanovic]

The make check-crates was still failing, but is now fixed in b588224 - I had to re-introduce the download-params feature as the MASP VP must always be available even without it for the SDK to compile

[tzemanovic]

The make check-crates was still failing, but is now fixed in b588224 - I had to re-introduce the download-params feature as the MASP VP must always be available even without it for the SDK to compile

So download-params wasn't enough on its own - I also had to bring back the validation feature too in 89eaa9f to prevent JS wasm bindgen leaking into our wasm build (I think this is due the combination of rand_core which pulls getrandom and masp_proof which enabled feature js in getrandom).

[tzemanovic]

so the problem was indeed in masp_proofs - anoma/masp#85

[tzemanovic]

I rm'd the "validation" feature again in https://github.com/anoma/namada/compare/89eaa9f610de6361c4bcd95c77f9dcb8a6d97537..2f3abec526148f599a567907d153fd7b9d2e45eb as it's not needed with the masp_proofs fix

[codecov]

Codecov Report

Attention: Patch coverage is 1.85185% with 159 lines in your changes missing coverage. Please review.

Project coverage is 53.91%. Comparing base (879a326) to head (d6212b9).
Report is 4 commits behind head on main.

Files	Patch %	Lines
crates/shielded_token/src/validation.rs	0.00%	158 Missing ⚠️
crates/node/src/lib.rs	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3419      +/-   ##
==========================================
- Coverage   53.92%   53.91%   -0.01%     
==========================================
  Files         317      318       +1     
  Lines      107575   107569       -6     
==========================================
- Hits        58011    58001      -10     
- Misses      49564    49568       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.