-
Notifications
You must be signed in to change notification settings - Fork 956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DI - shielded token #3466
DI - shielded token #3466
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3466 +/- ##
==========================================
+ Coverage 54.51% 54.55% +0.03%
==========================================
Files 323 324 +1
Lines 113288 113431 +143
==========================================
+ Hits 61762 61878 +116
- Misses 51526 51553 +27 ☔ View full report in Codecov by Sentry. |
44421be
to
ecfe104
Compare
Looks good to me except for the compilation issue with wasm tests |
ah, thx I missed this all the way back in the #3402 base |
ecfe104
to
061382b
Compare
49088fa
to
0028817
Compare
0028817
to
7f87875
Compare
7f87875
to
4f96b65
Compare
4f96b65
to
0fc23dd
Compare
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. ⛓️ Depends-On RequirementsRequirement based on the presence of
|
Describe your changes
Dependency injection for the shielded token - rm'ing cross-system dep on:
The newly added test
crates/systems/src/test.rs
ensures that there are no cross-deps between these systems. More to be added as they are refactored.Indicate on which release or other PRs this topic is based on
Depends-On: #3472
Checklist before merging to
draft