Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tests & refactor tx crate - alt (backport #3868) #3871

Open
wants to merge 10 commits into
base: 0.44.0
Choose a base branch
from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 2, 2024

Describe your changes

an alternative to #3835 (without the refactor of tx sections access 9842883, which breaks compatibility with hermes/gaia in a way I don't yet understand)

related to #1497

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

This is an automatic backport of pull request #3868 done by [Mergify](https://mergify.com).

(cherry picked from commit a7a752f)
(cherry picked from commit 9852755)
(cherry picked from commit f4c461f)
(cherry picked from commit 1618f4e)
(cherry picked from commit 1217e62)
(cherry picked from commit 7519ce9)
(cherry picked from commit 02eca6e)
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

Attention: Patch coverage is 81.89386% with 174 lines in your changes missing coverage. Please review.

Project coverage is 73.21%. Comparing base (2bd9a60) to head (59db279).

Files with missing lines Patch % Lines
crates/tx/src/section.rs 69.00% 137 Missing ⚠️
crates/tx/src/sign.rs 80.99% 23 Missing ⚠️
crates/tx/src/types.rs 98.39% 6 Missing ⚠️
crates/node/src/shell/finalize_block.rs 37.50% 5 Missing ⚠️
crates/node/src/shell/mod.rs 33.33% 2 Missing ⚠️
crates/node/src/shell/prepare_proposal.rs 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           0.44.0    #3871      +/-   ##
==========================================
+ Coverage   73.04%   73.21%   +0.17%     
==========================================
  Files         340      341       +1     
  Lines      104782   105150     +368     
==========================================
+ Hits        76536    76987     +451     
+ Misses      28246    28163      -83     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant