Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tests & refactor tx crate - alt (backport #3868) #3871

Merged
merged 10 commits into from
Oct 3, 2024

changelog: add #3835

59db279
Select commit
Loading
Failed to load commit list.
Merged

add tests & refactor tx crate - alt (backport #3868) #3871

changelog: add #3835
59db279
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 2, 2024 in 0s

73.21% (+0.17%) compared to 2bd9a60

View this Pull Request on Codecov

73.21% (+0.17%) compared to 2bd9a60

Details

Codecov Report

Attention: Patch coverage is 81.89386% with 174 lines in your changes missing coverage. Please review.

Project coverage is 73.21%. Comparing base (2bd9a60) to head (59db279).

Files with missing lines Patch % Lines
crates/tx/src/section.rs 69.00% 137 Missing ⚠️
crates/tx/src/sign.rs 80.99% 23 Missing ⚠️
crates/tx/src/types.rs 98.39% 6 Missing ⚠️
crates/node/src/shell/finalize_block.rs 37.50% 5 Missing ⚠️
crates/node/src/shell/mod.rs 33.33% 2 Missing ⚠️
crates/node/src/shell/prepare_proposal.rs 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           0.44.0    #3871      +/-   ##
==========================================
+ Coverage   73.04%   73.21%   +0.17%     
==========================================
  Files         340      341       +1     
  Lines      104782   105150     +368     
==========================================
+ Hits        76536    76987     +451     
+ Misses      28246    28163      -83     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.