Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid updating merkle paths of spent notes (backport #4018) #4051

Open
wants to merge 2 commits into
base: maint-0.45
Choose a base branch
from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 19, 2024

Describe your changes

Avoid updating merkle paths of spent notes. This should optimize the synchronous path of the shielded sync on the ledger client.

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

This is an automatic backport of pull request #4018 done by [Mergify](https://mergify.com).

(cherry picked from commit 550e03a)
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.05%. Comparing base (73c5d2a) to head (ced696f).
Report is 1 commits behind head on maint-0.45.

Additional details and impacted files
@@              Coverage Diff               @@
##           maint-0.45    #4051      +/-   ##
==============================================
- Coverage       74.06%   74.05%   -0.01%     
==============================================
  Files             341      341              
  Lines          106561   106571      +10     
==============================================
- Hits            78920    78919       -1     
- Misses          27641    27652      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant