Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #80: Update problem matcher #147

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Fixes #80: Update problem matcher #147

wants to merge 2 commits into from

Conversation

jonaprieto
Copy link
Collaborator

@jonaprieto jonaprieto commented Sep 5, 2024 •
edited
Loading

@jonaprieto jonaprieto self-assigned this Sep 5, 2024
@jonaprieto jonaprieto added this to the 0.2.4 milestone Sep 5, 2024
@jonaprieto jonaprieto changed the title Fix problem matcher Fix #80: Update problem matcher Sep 5, 2024
@jonaprieto jonaprieto changed the title Fix #80: Update problem matcher Fixes #80: Update problem matcher Sep 5, 2024
@jonaprieto jonaprieto marked this pull request as draft September 5, 2024 16:05
lukaszcz
lukaszcz approved these changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@lukaszcz lukaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work now!

@lukaszcz lukaszcz modified the milestones: 0.2.4, 0.2.5 Sep 5, 2024
@jonaprieto
Copy link
Collaborator Author

I'm not sure, I just tested it on another machine, and it didn't work. Did you test it with typecheckOn set to "none"

@lukaszcz
Copy link
Contributor

lukaszcz commented Sep 6, 2024

I'm not sure, I just tested it on another machine, and it didn't work. Did you test it with typecheckOn set to "none"

Oh, yes, it doesn't work with typecheckOn set to "none". It's a bit strange and random. For the first typecheck, I got only the first line of the error message. When I repeat the type checking, I don't get the error message at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukaszcz lukaszcz lukaszcz approved these changes

Assignees

@jonaprieto jonaprieto

Labels
fix maintenance
Projects
None yet
Milestone
0.2.5
Development

Successfully merging this pull request may close these issues.
2 participants
@jonaprieto @lukaszcz