Move public key check code from dependency. #69
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sripwoud
requested changes
Dec 22, 2022
circuits/circom/test/circuit.test.ts
Outdated
| circuit = await wasm_tester(join(__dirname, "test_ecdsa_check_pub_key.circom")); | ||
| }); | ||
|
|
||
| var test_ecdsa_verify = function (test_case: [bigint, bigint]) { |
There was a problem hiding this comment.
Check/fix linting errors
Well it's kind of independent, they can be chained in either direction. So I just merged main into this branch once #68 was merged into master. I'll be sure to clarify chaining between PRs in the description in the future! Unfortunately I have to close this because Snyk always fails for PRs from forks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to verify an ECDSA signature you have to validate the public key. Usually this is done outside the circuit to save computation. However, we need to prove membership in arbitrary lists of addresses, where the public keys may not be available to be checked. This means we have to check the public key inside the circuit.
We made a PR to our dependency, but it's unlikely to get merged. So instead we have moved the logic into this repo.