Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed .play to a promise function #269

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Changed .play to a promise function #269

wants to merge 2 commits into from

Conversation

DivyeshPuri
Copy link
Contributor

Fixes #267

Demo: https://ongaku-${PULL_REQUEST}.surge.sh

This PR is for [Anime Name].

  • This issue is for enhancement/bug fixing.
  • This issue is an addition to JSON database.
    • Pull Request Title is of form Added [Anime Name].
  • This addition is already on ongaku.
    • This PR is an improvement to current addition.
  • I have checked my addition locally and it is working and won't break existing entries.
  • I have gone through Contribution Guidelines.
  • This pull request will be closed if I failed to update it even once in a week.

@anshumanv
Copy link
Owner

anshumanv commented Apr 20, 2019 •
edited
Loading

Sori dp 😟, @starkblaze01 will take a look soon 🤗

@starkblaze01
Copy link
Collaborator

@DivyeshPuri, need more fixes.

@anshumanv
Copy link
Owner

anshumanv commented Oct 2, 2019 •
edited
Loading

Dp promise me you will complete this 😭

@anshumanv
Copy link
Owner

@DivyeshPuri doko?

@anshumanv
Copy link
Owner

@DivyeshPuri let's do some code instead of CS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DOMException: Failed to load because no supported source was found
3 participants
@DivyeshPuri @anshumanv @starkblaze01