Skip to content

Commit

Permalink
Minor updates
Browse files Browse the repository at this point in the history
Signed-off-by: Alina Buzachis <[email protected]>
  • Loading branch information
alinabuzachis committed Dec 4, 2024
1 parent c66a5bd commit 8a29f2c
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 17 deletions.
4 changes: 3 additions & 1 deletion plugins/modules/route53_ksk.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
DOCUMENTATION = r"""
module: route53_ksk
short_description: Manages a key-signing key (KSK)
version_added: 5.0.0
version_added: 9.2.0
description:
- Creates a new key-signing key (KSK) associated with a hosted zone.
You can only have two KSKs per hosted zone.
Expand Down Expand Up @@ -63,6 +63,8 @@
- amazon.aws.common.modules
- amazon.aws.region.modules
- amazon.aws.boto3
notes:
- This module does not support check_mode.
author:
- Alina Buzachis (@alinabuzachis)
"""
Expand Down
16 changes: 0 additions & 16 deletions plugins/modules/route53_zone.py
Original file line number Diff line number Diff line change
Expand Up @@ -286,12 +286,10 @@
from ansible_collections.amazon.aws.plugins.module_utils.retries import AWSRetry
from ansible_collections.amazon.aws.plugins.module_utils.route53 import get_tags
from ansible_collections.amazon.aws.plugins.module_utils.route53 import manage_tags
from ansible_collections.amazon.aws.plugins.module_utils.waiters import get_waiter

try:
from botocore.exceptions import BotoCoreError
from botocore.exceptions import ClientError
from botocore.exceptions import WaiterError
except ImportError:
pass # caught by AnsibleAWSModule

Expand Down Expand Up @@ -368,20 +366,6 @@ def ensure_dnssec(client, module, zone_id):
return changed


def wait(client, module, change_id):
try:
waiter = get_waiter(client, "resource_record_sets_changed")
waiter.wait(
Id=change_id,
WaiterConfig=dict(
Delay=5,
MaxAttempts=10,
),
)
except WaiterError as e:
module.fail_json_aws(e, msg="Timeout waiting for changes to be applied")


def create(matching_zones):
zone_in = module.params.get("zone").lower()
vpc_id = module.params.get("vpc_id")
Expand Down

0 comments on commit 8a29f2c

Please sign in to comment.